[webkit-reviews] review granted: [Bug 132329] [GTK] Enable skipped http/tests/media/hls/video-controls-live-stream.html : [Attachment 230689] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 132329: [GTK] Enable skipped
http/tests/media/hls/video-controls-live-stream.html
https://bugs.webkit.org/show_bug.cgi?id=132329

Attachment 230689: Patch
https://bugs.webkit.org/attachment.cgi?id=230689&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230689&action=review


> Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js:63
> +    configureControls: function() {
> +	   if (!this.controls.configured) {
> +	       this.configureInlineControls();
> +	       this.controls.configured = true;
> +	       this.addControls();
> +	   }
> +    },

Nit: you should use an early return here:

    if (this.controls.configured) 
	return;