[webkit-reviews] review granted: [Bug 132609] [GStreamer] Corrected typo : [Attachment 230909] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 6 09:05:11 PDT 2014
Martin Robinson <mrobinson at webkit.org> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 132609: [GStreamer] Corrected typo
https://bugs.webkit.org/show_bug.cgi?id=132609
Attachment 230909: Patch
https://bugs.webkit.org/attachment.cgi?id=230909&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230909&action=review
Please fix ChangeLog before landing.
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208
> , m_timeOfOverlappingSeek(-1)
> + , m_canFallBackToLastFinishedSeekPosition(false)
> , m_buffering(false)
This is a goo thing to add, I'd say, but you fail to mention it in the
ChangeLog.
More information about the webkit-reviews
mailing list