[webkit-reviews] review requested: [Bug 130322] Operator stretching: use size variants and glyph assembly from the MATH data : [Attachment 230897] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) | away 27/04 to 06/05 <fred.wang at free.fr> has asked  for
review:
Bug 130322: Operator stretching: use size variants and glyph assembly from the
MATH data
https://bugs.webkit.org/show_bug.cgi?id=130322

Attachment 230897: Patch
https://bugs.webkit.org/attachment.cgi?id=230897&action=review

------- Additional Comments from Frédéric Wang (:fredw) | away 27/04 to 06/05
<fred.wang at free.fr>
> Source/WebCore/css/mathml.css

I've kept the list of fonts for now, although this will eventually change
later.

> = nullptr;

done

> i think maxIndex is probably a size_t or an unsigned

done

> Still hit the assert

Gurpreet tried again yesterday with the latest version and she confirmed that
the changes to shouldAllowStretching prevents the assert with the Web fonts.
There is certainly something that we don't understand but I can't debug this on
Linux as this seems specific to Windows/Mac. So I think we can take the patch,
even if it won't improve the rendering with the default fonts for now. The two
remaining issues before being able to switch to OpenType fonts with a MATH
table for the default font-family is:

1) Ensuring that the fonts are available on test bots & at least Mac/iOS
(Windows has Cambria Math and Linux distributions have packages available)

2) Fixing bug 131839 for STIX Word and fonts of the GUST e-foundry group (bug
131839 comment 1). It will probably be best to let the font designers fix that
bug rather than adding some special code to handle that in WebKit.