[webkit-reviews] review denied: [Bug 132593] [Mac] Allow focus rings to redraw themselves if necessary : [Attachment 230883] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 5 20:21:50 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Dean Jackson
<dino at apple.com>'s request for review:
Bug 132593: [Mac] Allow focus rings to redraw themselves if necessary
https://bugs.webkit.org/show_bug.cgi?id=132593

Attachment 230883: Patch
https://bugs.webkit.org/attachment.cgi?id=230883&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230883&action=review


> Source/WebCore/rendering/RenderView.cpp:107
> +#if PLATFORM(MAC)
> +    , m_maximalOutlineSize(9)
> +#else

We can't do this. It will bloat all layers, and make all opaque things
non-opaque.

Why can't you just do this when a focus ring is showing?


More information about the webkit-reviews mailing list