[webkit-reviews] review granted: [Bug 132517] Implement scan backward and forward in video fullscreen. : [Attachment 230867] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 5 18:09:07 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 132517: Implement scan backward and forward in video fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=132517

Attachment 230867: Patch
https://bugs.webkit.org/attachment.cgi?id=230867&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230867&action=review


> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:95
> + at property (readonly) BOOL canScanForward;
> + at property (readonly) BOOL canScanBackward;
> + at property (readonly) BOOL canSeekToBeginning;
> + at property (readonly) BOOL canSeekToEnd;

Should these be nonatomic?


More information about the webkit-reviews mailing list