[webkit-reviews] review granted: [Bug 132509] [iOS][WK2] Prefetch DNS hostnames on tap highlight : [Attachment 230862] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 132509: [iOS][WK2] Prefetch DNS hostnames on tap highlight
https://bugs.webkit.org/show_bug.cgi?id=132509

Attachment 230862: Patch
https://bugs.webkit.org/attachment.cgi?id=230862&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230862&action=review


> Source/WebCore/dom/Element.cpp:1179
> +    if (linkAttribute.isEmpty())
> +	   return
document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkAttribute));
> +    return URL();

Looks like normal and early return statements are switched here.

> Source/WebCore/platform/network/DNS.h:34
> -void prefetchDNS(const String& hostname);
> +class URL;
> +
> +void prefetchDNS(const URL& absoluteURL);

I think that the original interface was superior, even though we had a bit of
duplicated code. The new interface is misleading - this function logically
takes a hostname, not a URL.