[webkit-reviews] review granted: [Bug 132380] [CSS Grid Layout] Guard RenderObject::isRenderGrid() method : [Attachment 230474] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 132380: [CSS Grid Layout] Guard RenderObject::isRenderGrid() method
https://bugs.webkit.org/show_bug.cgi?id=132380

Attachment 230474: Patch
https://bugs.webkit.org/attachment.cgi?id=230474&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230474&action=review


> Source/WebCore/rendering/RenderBox.cpp:2307
> +	   && !isFloating() && !isInline() &&
!cb->isFlexibleBoxIncludingDeprecated()
> +#if ENABLE(CSS_GRID_LAYOUT)
> +	   && !cb->isRenderGrid()
> +#endif

I am fine with this, it is supposed to be temporary.

When does it make sense to layout differently for
isFlexibleBoxIncludingDeprecated() and isRenderGrid()? From a quick view it
seems they share many similar "stretching" properties. Wouldn't it make sense
to replace isFlexibleBoxIncludingDeprecated() by something that accounts for
grid layout?