[webkit-reviews] review granted: [Bug 132569] Adapt inline SVG sizing behavior to Firefox and Blink : [Attachment 230851] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 5 14:03:28 PDT 2014
Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 132569: Adapt inline SVG sizing behavior to Firefox and Blink
https://bugs.webkit.org/show_bug.cgi?id=132569
Attachment 230851: Patch
https://bugs.webkit.org/attachment.cgi?id=230851&action=review
------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230851&action=review
> Source/WebCore/ChangeLog:14
> + "The basis of this change is to map explicit width and height
> + attributes to CSS properties, essentially promoting them to
> + presentation attributes. Note that implicit "100%" width and height
> + are not mapped.
You're missing an end quote mark.
> Source/WebCore/ChangeLog:39
> + (svg:root):
Either remove this line or put the text above on it.
> Source/WebCore/ChangeLog:45
> + And so it SVGSVGElement.
"is"
More information about the webkit-reviews
mailing list