[webkit-reviews] review denied: [Bug 131161] [CSS Regions] Elements with overflow:auto are not painted inside regions when following a float : [Attachment 230822] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 131161: [CSS Regions] Elements with overflow:auto are not painted inside
regions when following a float
https://bugs.webkit.org/show_bug.cgi?id=131161

Attachment 230822: Patch
https://bugs.webkit.org/attachment.cgi?id=230822&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230822&action=review


r-

> Source/WebCore/rendering/RenderLayer.cpp:5657
> +	       // Boxes inside flow threads don't have their logical left
computed to avoid
> +	       // floats. Instead, that information is kept in their
RenderBoxRegionInfo structure.
> +	       // As such, the layer bounds must be enlarged to encompass their
background rect
> +	       // to ensure intersecting them won't result in an empty rect,
which would eventually
> +	       // cause paint rejection.
> +	       if (flowThread) {
> +		   if (flowThread->style().isHorizontalWritingMode())
> +		       layerBounds.shiftMaxXEdgeTo(std::max(layerBounds.maxX(),
backgroundRect.rect().maxX()));
> +		   else
> +		       layerBounds.shiftMaxYEdgeTo(std::max(layerBounds.maxY(),
backgroundRect.rect().maxY()));
> +	       }

Don't run this code for columns, so change to if (flowThread &&
flowThread->isNamedRenderFlowThread())