[webkit-reviews] review granted: [Bug 132556] jsSubstring() should be lazy : [Attachment 230807] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 4 21:52:15 PDT 2014


Andreas Kling <akling at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 132556: jsSubstring() should be lazy
https://bugs.webkit.org/show_bug.cgi?id=132556

Attachment 230807: the patch
https://bugs.webkit.org/attachment.cgi?id=230807&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230807&action=review


r=me

> Source/JavaScriptCore/heap/MarkedBlock.cpp:73
> +    SamplingRegion samplingRegion((dtorType != MarkedBlock::None &&
blockState != New) ? "Calling destructors" : "sweeping");

Looks unrelated.


More information about the webkit-reviews mailing list