[webkit-reviews] review granted: [Bug 132553] [iOS][WK2] Special case ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture() for image documents : [Attachment 230804] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 4 19:41:01 PDT 2014


Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 132553: [iOS][WK2] Special case
ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture() for
image documents
https://bugs.webkit.org/show_bug.cgi?id=132553

Attachment 230804: Patch
https://bugs.webkit.org/attachment.cgi?id=230804&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230804&action=review


> Source/WebCore/html/ImageDocument.h:33
> +class HTMLImageElement;

Why is this here?

> Source/WebCore/html/ImageDocument.h:42
> +    Element* imageElement() const;

Can this type be more specific? Can it be a reference?

> Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:94
> +#if PLATFORM(IOS)

I think you should do this everywhere, not just iOS.


More information about the webkit-reviews mailing list