[webkit-reviews] review granted: [Bug 132319] CSS JIT: optimize direct / indirect adjacent's traversal backtracking : [Attachment 230693] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 132319: CSS JIT: optimize direct / indirect adjacent's traversal
backtracking
https://bugs.webkit.org/show_bug.cgi?id=132319

Attachment 230693: Patch
https://bugs.webkit.org/attachment.cgi?id=230693&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230693&action=review


Great patch and great test!

I'll update the LayoutTest's ChangeLog and commit manually.

> LayoutTests/ChangeLog:10
> +	   Since adjacent backtracking stack reference is pre-allocated
> +	   in prologue in http://trac.webkit.org/changeset/166834,
> +	   clearing stack phase is not needed. So we can drop

You don't need to repeat the text in this changelog. In the layout test
changelog, you can add any comment you have on your tests.