[webkit-reviews] review granted: [Bug 132539] Clear the JSString cache when under memory pressure. : [Attachment 230779] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 132539: Clear the JSString cache when under memory pressure.
https://bugs.webkit.org/show_bug.cgi?id=132539

Attachment 230779: Patch
https://bugs.webkit.org/attachment.cgi?id=230779&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230779&action=review


> Source/WebCore/platform/MemoryPressureHandler.cpp:112
> +    {
> +	   ReliefLogger log("Clearing JS string cache");
> +	   JSDOMWindow::commonVM().stringCache.clear();
> +    }

We really need to find a way for this to be less of a layering violation haven.