[webkit-reviews] review granted: [Bug 132522] Clean up ProcessThrottler : [Attachment 230749] Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 3 12:41:53 PDT 2014
Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 132522: Clean up ProcessThrottler
https://bugs.webkit.org/show_bug.cgi?id=132522
Attachment 230749: Fix
https://bugs.webkit.org/attachment.cgi?id=230749&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230749&action=review
r=me, but I might have found a bug.
> Source/WebKit2/ChangeLog:21
> + longer needs request a reply from SetViewState, and WebPageProxy can
lose all the 'hiding'
"needs to"
> Source/WebKit2/UIProcess/WebPageProxy.cpp:1101
> + else if (!m_activityToken)
> + m_activityToken =
std::make_unique<ProcessThrottler::ForegroundActivityToken>(m_process->throttle
r());
If I already have an activity token, but it is Background instead of
Foreground, won't this !m_activityToken check prevent me from entering the
Foreground state when I should?
Seems like you should check !m_activityToken ||
m_activityToken->isBackgroundActivityToken() or something.
More information about the webkit-reviews
mailing list