[webkit-reviews] review granted: [Bug 132512] [iOS][WK2] Support speculative tiling : [Attachment 230736] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 132512: [iOS][WK2] Support speculative tiling
https://bugs.webkit.org/show_bug.cgi?id=132512

Attachment 230736: Patch
https://bugs.webkit.org/attachment.cgi?id=230736&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230736&action=review


> Source/WebCore/ChangeLog:9
> +	   Move ScrollView::setScrollVelocity() and
ScrollView::computeCoverageRect() to FrameView.
> +	   When speculative tiling is disabled, return an unmodified exposed
rect.

You could leave it in ScrollView, override in FrameView and check
m_speculativeTilingEnabled before calling to the superclass. But, was there a
reason it was in ScrollView itself in the first place?

> Source/WebCore/page/FrameView.cpp:4125
> +FloatRect FrameView::computeCoverageRect(double horizontalMargin, double
verticalMargin) const

It still makes me sad that this is separate from the one in TileController
(that this logic is spread out).