[webkit-reviews] review granted: [Bug 132519] [EFL][WK2] Refactor favicon database APIs : [Attachment 230746] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 132519: [EFL][WK2] Refactor favicon database APIs
https://bugs.webkit.org/show_bug.cgi?id=132519

Attachment 230746: Patch
https://bugs.webkit.org/attachment.cgi?id=230746&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230746&action=review


> Source/WebKit2/ChangeLog:11
> +	   It's simple to use but it always adds the callback to EwkView
although applications does not use favicon.

I agree that we don't need to support two options to get favicon data. However,
I don't think first option has big overhead to add favicon callback in
application side. Anyway, I don't have pros to keep first way. So, r+ed.

> Tools/ChangeLog:8
> +	   * MiniBrowser/efl/main.c: Use ewk_view_favicon_get instead of
ewk_view_favicon_get.

Use ewk_view_favicon_get instead of ewk_view_favicon_get. => Use
ewk_favicon_database_icon_get instead of ewk_view_favicon_get. ?

> Tools/MiniBrowser/efl/main.c:327
> +    Evas_Object* favicon = ewk_favicon_database_icon_get(database, url,
evas_object_evas_get(ewk_view));

Looks wrong * place in Evas_Object* favicon