[webkit-reviews] review denied: [Bug 132506] HTMLMediaElement should exitFullscreen when view is removed from the window. : [Attachment 230728] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 2 18:27:30 PDT 2014


mitz at webkit.org <mitz at webkit.org> has denied Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 132506: HTMLMediaElement should exitFullscreen when view is removed from
the window.
https://bugs.webkit.org/show_bug.cgi?id=132506

Attachment 230728: Patch
https://bugs.webkit.org/attachment.cgi?id=230728&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230728&action=review


> Source/WebCore/page/Page.cpp:887
> +#if PLATFORM(IOS)
> +    else {
> +	   for (Frame* frame = &mainFrame(); frame; frame =
frame->tree().traverseNext())
> +	       frame->dismissModalFullscreen();
> +    }
> +#endif

There shouldn’t be (and there currently isn’t) any platform-specific code in
Page.cpp.


More information about the webkit-reviews mailing list