[webkit-reviews] review granted: [Bug 132494] Implement FormData decoding using KeyedDecoder : [Attachment 230706] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 2 15:22:26 PDT 2014


Tim Horton <thorton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 132494: Implement FormData decoding using KeyedDecoder
https://bugs.webkit.org/show_bug.cgi?id=132494

Attachment 230706: Patch
https://bugs.webkit.org/attachment.cgi?id=230706&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230706&action=review


> Source/WebCore/platform/network/FormData.cpp:679
> +    if (!decoder.decodeObjects("elements", data->m_elements,
[](KeyedDecoder& decoder, FormDataElement& element) {
> +	   return decodeElement(decoder, element);
> +    }))
> +	   return nullptr;

I will note that this looks pretty bizarre.


More information about the webkit-reviews mailing list