[webkit-reviews] review canceled: [Bug 131515] Inlining native functions into the JavaScript in the FTL : [Attachment 230610] Native runtime library inlining in FTL

[bugzilla-daemon at webkit.org]

Matthew Mirman <mmirman at apple.com> has canceled Matthew Mirman
<mmirman at apple.com>'s request for review:
Bug 131515: Inlining native functions into the JavaScript in the FTL
https://bugs.webkit.org/show_bug.cgi?id=131515

Attachment 230610: Native runtime library inlining in FTL
https://bugs.webkit.org/attachment.cgi?id=230610&action=review

------- Additional Comments from Matthew Mirman <mmirman at apple.com>
Removed some errant JS_EXPORT_PRIVATEs which fixed building with --debug.

Ran run-javascript-core tests with no errors.


Ran "run-webkit-tests --debug"	with the following errors which I believe to be
preexisting and not results of this patch (please review):  

[1429/33776]
compositing/hidpi-compositing-vs-non-compositing-check-on-testing-framework.htm
l failed unexpectedly (reference mismatch)
[2389/33776]
compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-backgro
und.html failed unexpectedly (reference mismatch)
[5469/33776] fast/backgrounds/gradient-background-shadow.html failed
unexpectedly (reference mismatch)
[9950/33776] fast/dom/shadow/content-element-outside-shadow.html passed
unexpectedly				   
  fast/gradients/css3-color-stop-invalid.html -> ref test hashes didn't match
but diff passed
[12549/33776] fast/images/pdf-as-image-crop-box.html failed unexpectedly
(reference mismatch)		       
[12797/33776] fast/multicol/newmulticol/clipping.html passed unexpectedly      
				
[13804/33776] fast/scrolling/scroll-select-list.html passed unexpectedly       
		    
[14333/33776] fast/sub-pixel/file-upload-control-at-fractional-offset.html
passed unexpectedly   
[16550/33776] fast/workers/worker-call.html passed unexpectedly 	       
				      
[16845/33776] inspector-protocol/profiler/console-profile.html failed
unexpectedly (text diff)						       
	     
[17855/33776] mathml/wbr-in-mroot-crash.html passed unexpectedly	       
			     
[20007/33776] mathml/presentation/mspace-units.html passed unexpectedly        
					
[21389/33776] media/media-controls-invalid-url.html passed unexpectedly        
							 
[22836/33776] jquery/manipulation.html failed unexpectedly (text diff)	       
								  
  svg/css/svg-resource-fragment-identifier-img-src.html -> ref test hashes
didn't match but diff passed					     
  svg/stroke/non-scaling-stroke-pattern.svg -> ref test hashes didn't match but
diff passed	    
[31391/33776] webgl/1.0.2/conformance/ogles/GL/build/build_009_to_016.html
passed unexpectedly				       
[31762/33776]
webgl/1.0.2/conformance/glsl/misc/shader-uniform-packing-restrictions.html
failed unexpectedly (text diff) 		   
[33721/33776]
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html failed
unexpectedly (test timed out, text diff)