[webkit-reviews] review granted: [Bug 132484] Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem: : [Attachment 230690] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 132484: Implement new delegate method
-sharingService:sourceFrameOnScreenForShareItem:
https://bugs.webkit.org/show_bug.cgi?id=132484

Attachment 230690: Patch v1
https://bugs.webkit.org/attachment.cgi?id=230690&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review


> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373
> +    Node* node =
page->contextMenuController().context().hitTestResult().innerNode();

any reason to null check node?

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384
> +	   ASSERT_NOT_REACHED();

why this assert, and then a happy handling of it on the next line?