[webkit-reviews] review granted: [Bug 132464] Reduce calls to CFURLCacheCopySharedURLCache : [Attachment 230675] Patch with assert and raw pointer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 2 11:29:47 PDT 2014
Alexey Proskuryakov <ap at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 132464: Reduce calls to CFURLCacheCopySharedURLCache
https://bugs.webkit.org/show_bug.cgi?id=132464
Attachment 230675: Patch with assert and raw pointer
https://bugs.webkit.org/attachment.cgi?id=230675&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230675&action=review
> Source/WebKit2/NetworkProcess/mac/NetworkResourceLoaderMac.mm:89
> + static CFURLCacheRef cache = CFURLCacheCopySharedURLCache();
I'd also add ASSERT(isMainThread()) here, as this initialization is not thread
safe.
More information about the webkit-reviews
mailing list