[webkit-reviews] review granted: [Bug 132464] Reduce calls to CFURLCacheCopySharedURLCache : [Attachment 230655] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 132464: Reduce calls to CFURLCacheCopySharedURLCache
https://bugs.webkit.org/show_bug.cgi?id=132464

Attachment 230655: Patch
https://bugs.webkit.org/attachment.cgi?id=230655&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230655&action=review


> Source/WebKit2/NetworkProcess/mac/NetworkResourceLoaderMac.mm:89
> +    static RetainPtr<CFURLCacheRef> cache =
adoptCF(CFURLCacheCopySharedURLCache());

This can't be a RetainPtr, because we don't want exit time destructors. A plain
pointer would be appropriate.

An ASSERT in debug builds would ensure that we don't break this optimization,
although that may be overkill.