[webkit-reviews] review granted: [Bug 132437] Add a DFG function whitelist : [Attachment 230634] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 132437: Add a DFG function whitelist
https://bugs.webkit.org/show_bug.cgi?id=132437

Attachment 230634: Patch
https://bugs.webkit.org/attachment.cgi?id=230634&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230634&action=review


r=me

> Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp:70
> +	   // Get rid of newlines at the end of the strings.

"ends"

> Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp:73
> +	   if (line[length-1] == '\n') {
> +	       line[length-1] = '\0';

spacing

> Source/JavaScriptCore/dfg/DFGFunctionWhitelist.h:48
> +    HashSet<String> m_functionNames;

You should call this "entries" or something. It's not just names -- it's
whitelist entries, which can be names or hashes or both concatenated.