[webkit-reviews] review granted: [Bug 132454] REGRESSION (WebKit2) Need to support Learn button : [Attachment 230638] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 132454: REGRESSION (WebKit2) Need to support Learn button
https://bugs.webkit.org/show_bug.cgi?id=132454

Attachment 230638: Patch
https://bugs.webkit.org/attachment.cgi?id=230638&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230638&action=review


> Source/WebKit2/ChangeLog:12
> +	   the button when appropriate as well as the implemetation of the
action

typo: implemetation

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:838
> +    CGRect presentationRect = _page->editorState().selectionRects[0].rect();


You don't need to create this outside of the if() branch.

The compiler cannot optimize this out because of the objc-msgsend below.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:920
> +	   if (!UIKeyboardEnabledInputModesAllowOneToManyShortcuts())

lol at the name :)