[webkit-reviews] review granted: [Bug 132442] Fullscreen UI does not appear after WebProcess has crashed : [Attachment 230616] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeremy Jones <jeremyj-wk at apple.com>'s
request for review:
Bug 132442: Fullscreen UI does not appear after WebProcess has crashed
https://bugs.webkit.org/show_bug.cgi?id=132442

Attachment 230616: Patch
https://bugs.webkit.org/attachment.cgi?id=230616&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230616&action=review


> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:595
> +    m_playerViewController = nil;

Not retained?

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:596
> +    m_viewController = nil;

Not retained?

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:597
> +    m_window = nil;

Not retained?

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:599
> +    m_videoLayer = nil;

Not retained?

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:601
> +    m_videoLayerContainer = nil;

Not retained?

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h:50
> +    void invalidate();

Should mark this virtual and override, and also private instead of public.