[webkit-reviews] review granted: [Bug 132435] [iOS][WK2] The highlight view needs to be in WKWebView coordinates : [Attachment 230603] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 1 13:25:31 PDT 2014


Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 132435: [iOS][WK2] The highlight view needs to be in WKWebView coordinates
https://bugs.webkit.org/show_bug.cgi?id=132435

Attachment 230603: Patch
https://bugs.webkit.org/attachment.cgi?id=230603&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230603&action=review


> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:375
> +	   RetainPtr<UIColor> highlightUIKitColor = adoptNS([[UIColor alloc]
initWithRed:(color.red() / 255.0) green:(color.green() / 255.0)
blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)]);

We really need something for this in Color or somewhere.


More information about the webkit-reviews mailing list