[webkit-reviews] review granted: [Bug 132066] REGRESSION (r168046): [New Multicolumn] Selection into and out of column-span elements doesn't work : [Attachment 230596] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 132066: REGRESSION (r168046): [New Multicolumn] Selection into and out of
column-span elements doesn't work
https://bugs.webkit.org/show_bug.cgi?id=132066

Attachment 230596: Patch
https://bugs.webkit.org/attachment.cgi?id=230596&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230596&action=review


>>> Source/WebCore/rendering/RenderView.cpp:59
>>> +	 RenderObject* m_current;
>> 
>> RenderPtr<RenderObject> please - i dream of having these things not
disappearing from beneath us :(
>> 
>> Even though the current uses imply no state mutation, i don't like the idea
of making an "iterator" that could be accidentally used in a context that leads
to mutation
> 
> I don't think this is an appropriate place for RenderPtr. This is just a
read-only loop of the selected objects. Nothing is mutated. The iterator is
confined to the .cpp file, so it's not going to see any weird usage. If this
were longer-lasting or designed for re-use I would see your point, but there's
no use case for this that would make any sense in the presence of mutation.

okie dokie