[webkit-reviews] review granted: [Bug 130955] [WebGL][OpenGLES] Enable MSAA support for WebGL Canvas : [Attachment 228146] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Byungseon Shin <sun.shin at lge.com>'s
request for review:
Bug 130955: [WebGL][OpenGLES] Enable MSAA support for WebGL Canvas
https://bugs.webkit.org/show_bug.cgi?id=130955

Attachment 228146: Patch
https://bugs.webkit.org/attachment.cgi?id=228146&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228146&action=review


It would be great if we could write a test for this.

> Source/WebCore/ChangeLog:10
> +	   - Imagination OpenGLES GPU Driver alreay support MSAA, so we

Typo: already

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:118
> +	   GLint sampleCount = std::min(8, maxSampleCount);
> +	   if (sampleCount > maxSampleCount)
> +	       sampleCount = maxSampleCount;

You don't need the if clause. sampleCount is already less than or equal to
maxSampleCount.