[webkit-reviews] review granted: [Bug 130985] ThemeMac should use std::array instead of IntSize* for control sizes : [Attachment 228199] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 31 13:57:26 PDT 2014


Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 130985: ThemeMac should use std::array instead of IntSize* for control
sizes
https://bugs.webkit.org/show_bug.cgi?id=130985

Attachment 228199: Patch
https://bugs.webkit.org/attachment.cgi?id=228199&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228199&action=review


> Source/WebCore/platform/mac/ThemeMac.mm:158
> +static LengthSize sizeFromNSControlSize(NSControlSize nsControlSize, const
LengthSize& zoomedSize, float zoomFactor,const std::array<IntSize, 3>& sizes)

Missing space after comma here.

> Source/WebCore/platform/mac/ThemeMac.mm:271
> +    static const std::array<IntSize, 3> sizes = { {IntSize(14, 14),
IntSize(12, 12), IntSize(10, 10)} };

I think there should be spaces inside the inner "{}" here too, not just the
outer ones.


More information about the webkit-reviews mailing list