[webkit-reviews] review granted: [Bug 130984] Synchronize Web process remote layer tree commits with CoreAnimation commits in the UI process : [Attachment 228193] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 130984: Synchronize Web process remote layer tree commits with
CoreAnimation commits in the UI process
https://bugs.webkit.org/show_bug.cgi?id=130984

Attachment 228193: patch
https://bugs.webkit.org/attachment.cgi?id=228193&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228193&action=review


> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:293
> +    m_layerCommitObserver = adoptCF(CFRunLoopObserverCreate(0,
kCFRunLoopBeforeWaiting | kCFRunLoopExit, true, DidCommitLayersRunLoopOrder,
coreAnimationDidCommitLayersCallback, &context));

Do we need to explicitly invalidate this guy in the destructor?

> Source/WebKit2/WebProcess/WebPage/DrawingArea.h:144
> +    virtual void didSwapBackingStore() { }

Not super keen on this name.

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:116
> +    bool m_hasFlushDeferredWhileWaitingForBackingStoreSwap;

hadFlushDeferredWhileWaitingForBackingStoreSwap?