[webkit-reviews] review granted: [Bug 130965] [CMake] Stop checking for WTF_USE_ICU_UNICODE. : [Attachment 228172] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 31 07:11:11 PDT 2014
Martin Robinson <mrobinson at webkit.org> has granted Raphael Kubo da Costa
(:rakuco) <rakuco at webkit.org>'s request for review:
Bug 130965: [CMake] Stop checking for WTF_USE_ICU_UNICODE.
https://bugs.webkit.org/show_bug.cgi?id=130965
Attachment 228172: Patch
https://bugs.webkit.org/attachment.cgi?id=228172&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228172&action=review
> Source/JavaScriptCore/CMakeLists.txt:30
> + "${ICU_INCLUDE_DIRS}"
I'm pretty sure you don't want parenthesis here, since there may be more than
one directory.
More information about the webkit-reviews
mailing list