[webkit-reviews] review denied: [Bug 130958] Use OwnPtr|PassOwnPtr to pass a pointer of NavigatorContentUtilsClient instance : [Attachment 228153] Patch for ews
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 31 06:46:58 PDT 2014
Anders Carlsson <andersca at apple.com> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 130958: Use OwnPtr|PassOwnPtr to pass a pointer of
NavigatorContentUtilsClient instance
https://bugs.webkit.org/show_bug.cgi?id=130958
Attachment 228153: Patch for ews
https://bugs.webkit.org/attachment.cgi?id=228153&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
The patch itself looks good but it should use std::unique_ptr instead of
OwnPtr/PassOwnPtr!
More information about the webkit-reviews
mailing list