[webkit-reviews] review granted: [Bug 129740] [EFL][WK2] Add ewk APIs to control TLS error policy on WebContext. : [Attachment 228170] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 31 04:01:11 PDT 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>'s request for review:
Bug 129740: [EFL][WK2] Add ewk APIs to control TLS error policy on WebContext.
https://bugs.webkit.org/show_bug.cgi?id=129740

Attachment 228170: patch
https://bugs.webkit.org/attachment.cgi?id=228170&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228170&action=review


LGTM except for a comment.

>
Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:34
> +	   m_baseURL = soup_uri_new("https://127.0.0.1/");

We can move this to out of if ~ else scope. Can't we move this to 40 line ?


More information about the webkit-reviews mailing list