[webkit-reviews] review granted: [Bug 130934] Subpixel rendering: Simple line layout should not round to integral position while painting. : [Attachment 228117] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 130934: Subpixel rendering: Simple line layout should not round to integral
position while painting.
https://bugs.webkit.org/show_bug.cgi?id=130934

Attachment 228117: Patch
https://bugs.webkit.org/attachment.cgi?id=228117&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228117&action=review


> Source/WebCore/ChangeLog:17
> +	   Without RenderLayer:
> +	   Renderer's layout position (10.5px, 10.5px) -> rounded and painted
at (11px, 11px)
> +
> +	   With RenderLayer:
> +	   Rendere's layout position (10.5px, 10.5px) -> RenderLayer position
(10.5px, 10.5px) ->
> +	   renderer's relative pos (0px, 0px) -> rounded and painted at (0px,
0p) which
> +	   translates to (10.5px, 10.5px) (vs. (11px, 11px)

I don't think it's necessary to include the math in the changelog. If you want
to preserve this info for the future, put it in the bugzilla bug.