[webkit-reviews] review granted: [Bug 129669] Move the rest of Source/WebCore/html/ code to std::unique_ptr : [Attachment 227789] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 129669: Move the rest of Source/WebCore/html/ code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=129669

Attachment 227789: Patch
https://bugs.webkit.org/attachment.cgi?id=227789&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227789&action=review


> Source/WebCore/html/FormController.cpp:219
> +    return std::move(savedFormState);

Is move really needed here?

> Source/WebCore/html/FormController.cpp:289
> +    FormKeyGenerator() = default;

Does this constructor even have to be defined?

> Source/WebCore/html/FormController.cpp:399
> +    auto keyGenerator = std::make_unique<FormKeyGenerator>();

Maybe FormKeyGenerator can just be allocated on the stack?

> Source/WebCore/html/FormController.cpp:459
> +	   std::unique_ptr<SavedFormState> state =
SavedFormState::deserialize(stateVector, i);

auto.