[webkit-reviews] review granted: [Bug 130920] [CSS Grid Layout] The 'auto' height must be adapted to the item's margin. : [Attachment 228097] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 130920: [CSS Grid Layout] The 'auto' height must be adapted to the item's
margin.
https://bugs.webkit.org/show_bug.cgi?id=130920

Attachment 228097: Patch
https://bugs.webkit.org/attachment.cgi?id=228097&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228097&action=review


>
LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.tx
t:17
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS

I’m not really happy with these check-layout tests. Could we make this a
reference test instead perhaps?