[webkit-reviews] review granted: [Bug 130725] Web Inspector: AXI: support for live regions : [Attachment 228103] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted James Craig
<jcraig at apple.com>'s request for review:
Bug 130725: Web Inspector: AXI: support for live regions
https://bugs.webkit.org/show_bug.cgi?id=130725

Attachment 228103: patch
https://bugs.webkit.org/attachment.cgi?id=228103&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228103&action=review


> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:366
> +		   if (liveRegionStatusToken ===
DOMAgent.AccessibilityPropertiesLiveRegionStatus.Assertive)

This could be a switch with cases.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:370
> +		   if (liveRegionStatus !== "" &&
accessibilityProperties.liveRegionAtomic === true) {

No need for !== "".