[webkit-reviews] review granted: [Bug 130746] WebProcesses use lots of cpu in the background if there are a lot of plugins. : [Attachment 227980] reworked patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 130746: WebProcesses use lots of cpu in the background if there are a lot
of plugins.
https://bugs.webkit.org/show_bug.cgi?id=130746

Attachment 227980: reworked patch
https://bugs.webkit.org/attachment.cgi?id=227980&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227980&action=review


> Source/WebKit2/PluginProcess/PluginProcess.cpp:264
> +    for (auto it = m_webProcessConnections.begin(), end =
m_webProcessConnections.end(); it != end; ++it) {
> +	   WebProcessConnection* connection = it->get();
> +	   connection->audioHardwareDidBecomeActive();
> +    }

This can use range for.

> Source/WebKit2/PluginProcess/PluginProcess.cpp:272
> +    for (auto it = m_webProcessConnections.begin(), end =
m_webProcessConnections.end(); it != end; ++it) {
> +	   WebProcessConnection* connection = it->get();
> +	   connection->audioHardwareDidBecomeInactive();
> +    }

Ditto.

> Source/WebKit2/PluginProcess/PluginProcess.h:45
> +    public WebCore::AudioHardwareListener::Client

Please put this on the same line. I also don't think it needs to be public.

> Source/WebKit2/PluginProcess/PluginProcess.h:102
> +    //AudioHardwareListenerClient

Missing space after //.