[webkit-reviews] review granted: [Bug 130727] Eliminate a sync cancelComposition call in WebPageProxy::editorStateChanged : [Attachment 228056] with a build fix

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 130727: Eliminate a sync cancelComposition call in
WebPageProxy::editorStateChanged
https://bugs.webkit.org/show_bug.cgi?id=130727

Attachment 228056: with a build fix
https://bugs.webkit.org/attachment.cgi?id=228056&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228056&action=review


>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4114
>> +printf("didChangeSelection. hasComposition =
%u，ignoreCompositionSelectionChange ＝%u, isNone = %u\n",
frame.editor().hasComposition(),
frame.editor().ignoreCompositionSelectionChange(), frame.selection().isNone());

> 
> You have a printf here.

You probably don't want to leave this in :-)