[webkit-reviews] review granted: [Bug 121562] [MSE] Implement support for SourceBuffer.remove() : [Attachment 228072] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 28 11:34:29 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 121562: [MSE] Implement support for SourceBuffer.remove()
https://bugs.webkit.org/show_bug.cgi?id=121562
Attachment 228072: Patch
https://bugs.webkit.org/attachment.cgi?id=228072&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228072&action=review
> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:246
> + m_source->openIfInEndedState();
You NULL check m_source above, do you need to so so here as well?
More information about the webkit-reviews
mailing list