[webkit-reviews] review granted: [Bug 130889] Fix recently-introduced off-by-one error in centerTruncateToBuffer : [Attachment 228030] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 28 10:07:35 PDT 2014
Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 130889: Fix recently-introduced off-by-one error in centerTruncateToBuffer
https://bugs.webkit.org/show_bug.cgi?id=130889
Attachment 228030: Patch
https://bugs.webkit.org/attachment.cgi?id=228030&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228030&action=review
> Source/WebKit/mac/ChangeLog:12
> + (+[WebStringTruncator initialize]): Added threading initialization,
needed for main
> + thread assertions in string truncator code.
I'm confused about how this worked before - you didn't add any new assertions
in this patch. Is something like this needed on iOS too?
More information about the webkit-reviews
mailing list