[webkit-reviews] review granted: [Bug 130874] A TrailingObject's endpoint might get decremented twice : [Attachment 228007] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 28 01:05:11 PDT 2014


Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 130874: A TrailingObject's endpoint might get decremented twice
https://bugs.webkit.org/show_bug.cgi?id=130874

Attachment 228007: Patch
https://bugs.webkit.org/attachment.cgi?id=228007&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Code change looks fine. Not sure what the point is of writing such a long
change log. If this is really hard to understand, then I think we would need a
comment instead of a change log entry. Next time you find you are writing a log
this long, I suggest talking to another WebKit contributor in person. Together
you can probably come up with a shorter explanation. I find that the process of
talking through it out loud helps.


More information about the webkit-reviews mailing list