[webkit-reviews] review granted: [Bug 130714] Adopt range-based for loops to TextCheckerEnchant : [Attachment 228017] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 28 00:17:26 PDT 2014
Darin Adler <darin at apple.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 130714: Adopt range-based for loops to TextCheckerEnchant
https://bugs.webkit.org/show_bug.cgi?id=130714
Attachment 228017: Patch
https://bugs.webkit.org/attachment.cgi?id=228017&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228017&action=review
> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:56
> + for (const auto& dictionary : m_enchantDictionaries)
I would have suggested auto& without the const for all of these loops. While I
understand that we can say const, it adds very little.
More information about the webkit-reviews
mailing list