[webkit-reviews] review granted: [Bug 130721] Web Inspector: AXI: expose what elements get generic "clickable" status : [Attachment 227968] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted James Craig
<jcraig at apple.com>'s request for review:
Bug 130721: Web Inspector: AXI: expose what elements get generic "clickable"
status
https://bugs.webkit.org/show_bug.cgi?id=130721

Attachment 227968: patch
https://bugs.webkit.org/attachment.cgi?id=227968&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227968&action=review


> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1053
> +	   // If we've reached the body and this is not a control element, do
not expose press action for this element unless resultFilter is
ignoreBodyElement.

IncludeBodyElement?

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1532
> +		   MouseButtonListenerResultFilter filter = IncludeBodyElement;


Can be inline, no need for the var.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:364
> +			   mouseEventTextValue = WebInspector.UIString("Yes");

Could just hide this row if it is the same node. Having Clickable: Yes, Click
Listener: Yes isn't that useful.