[webkit-reviews] review granted: [Bug 130775] [Bindings] constants are always typed to 'int' : [Attachment 227999] (actual) patch - as per Darin's review

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 130775: [Bindings] constants are always typed to 'int'
https://bugs.webkit.org/show_bug.cgi?id=130775

Attachment 227999: (actual) patch - as per Darin's review
https://bugs.webkit.org/attachment.cgi?id=227999&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227999&action=review


> LayoutTests/fast/dom/constants.html:83
> +    shouldBe("nodeFilter.SHOW_ALL", 4294967295);

I would have written this as 0xFFFFFFFF.

> LayoutTests/fast/dom/constants.html:100
> +    shouldBe("window.NodeFilter.SHOW_ALL", 4294967295);

Ditto.