[webkit-reviews] review granted: [Bug 130850] Convert yet more of HTMLConverter to C++ : [Attachment 227994] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 27 16:30:52 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 130850: Convert yet more of HTMLConverter to C++
https://bugs.webkit.org/show_bug.cgi?id=130850

Attachment 227994: Patch
https://bugs.webkit.org/attachment.cgi?id=227994&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227994&action=review


> Source/WebCore/editing/cocoa/HTMLConverter.mm:560
> +NSAttributedString *HTMLConverter::convert()

This should really return a RetainPtr<NSAttributedString>.


More information about the webkit-reviews mailing list