[webkit-reviews] review denied: [Bug 130775] [Bindings] constants are always typed to 'int' : [Attachment 227918] patch - for review

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Antonio Gomes <tonikitoo at webkit.org>'s
request for review:
Bug 130775: [Bindings] constants are always typed to 'int'
https://bugs.webkit.org/show_bug.cgi?id=130775

Attachment 227918: patch - for review
https://bugs.webkit.org/attachment.cgi?id=227918&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227918&action=review


Fix is good, but LayoutTests part of patch is wrong.

> LayoutTests/fast/dom/constants-expected.txt:30
> -PASS: nodeFilter.SHOW_ALL should be -1 and is.
> +FAIL: nodeFilter.SHOW_ALL should be -1 but instead is 4294967295.

This is wrong.

We should fix the fast/dom/constants.html test itself, which we now believe was
expecting the wrong thing.

We should not instead update the expected results to show failure!

> Source/WebCore/ChangeLog:16
> +	   NodeFilter.SHOW_ALL (0xFFFFFF).

Should have 8 Fs there, not 6.