[webkit-reviews] review granted: [Bug 130857] Avoid fetching JSObject::structure() repeatedly in putDirectInternal. : [Attachment 227974] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 27 15:20:12 PDT 2014


Mark Hahnenberg <mhahnenberg at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 130857: Avoid fetching JSObject::structure() repeatedly in
putDirectInternal.
https://bugs.webkit.org/show_bug.cgi?id=130857

Attachment 227974: Patch
https://bugs.webkit.org/attachment.cgi?id=227974&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227974&action=review


r=me

> Source/JavaScriptCore/runtime/JSObject.h:1346
> +    if (Structure* newStructure =
Structure::addPropertyTransitionToExistingStructure(this->structure(),
propertyName, attributes, specificFunction, offset)) {

s/this->structure()/structure/ right?


More information about the webkit-reviews mailing list