[webkit-reviews] review denied: [Bug 130848] Filter: pass by ref const on applyScale methods : [Attachment 227960] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Adenilson Cavalcanti Silva
<savagobr at yahoo.com>'s request for review:
Bug 130848: Filter: pass by ref const on applyScale methods
https://bugs.webkit.org/show_bug.cgi?id=130848

Attachment 227960: Patch
https://bugs.webkit.org/attachment.cgi?id=227960&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227960&action=review


Not sure why you are doing that. passing a reference to a float is not more or
less expecive than passing the value itself. All the float references should be
turned back to normal float arguments.

> Source/WebCore/platform/graphics/filters/Filter.h:50
> +    virtual float applyHorizontalScale(const float& value) const { return
value * m_filterResolution.width(); }
> +    virtual float applyVerticalScale(const float& value) const { return
value * m_filterResolution.height(); }

there is no need to make the float a reference, it doesn't save anything.

> Source/WebCore/svg/graphics/filters/SVGFilter.cpp:39
> +float SVGFilter::applyHorizontalScale(const float& value) const

Ditto.