[webkit-reviews] review granted: [Bug 130599] [GTK] Add support for GTK3 plugins : [Attachment 227446] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 130599: [GTK] Add support for GTK3 plugins
https://bugs.webkit.org/show_bug.cgi?id=130599

Attachment 227446: Patch
https://bugs.webkit.org/attachment.cgi?id=227446&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227446&action=review


> Source/WebKit2/PlatformGTK.cmake:524
> +    set(PluginProcess2_EXECUTABLE_NAME WebKitPluginProcess2)
> +    list(APPEND PluginProcess2_INCLUDE_DIRECTORIES

We use WebCorePlatformGTK2, so I think this should be PluginProcessGTK2 to
maintain consistency.

> Source/WebKit2/PlatformGTK.cmake:630
> -    list(APPEND PluginProcess_MESSAGES_IN_FILES
> +    list(APPEND PluginProcess2_MESSAGES_IN_FILES
>	   PluginProcess/PluginControllerProxy.messages.in
>	   PluginProcess/PluginProcess.messages.in
>	   PluginProcess/WebProcessConnection.messages.in
>  
>	   Shared/Plugins/NPObjectMessageReceiver.messages.in
>      )
> -    GENERATE_WEBKIT2_MESSAGE_SOURCES(PluginProcess_SOURCES
"${PluginProcess_MESSAGES_IN_FILES}")
> +    GENERATE_WEBKIT2_MESSAGE_SOURCES(PluginProcess2_SOURCES
"${PluginProcess2_MESSAGES_IN_FILES}")

These files are generated in the shared CMakeLists.txt file now, so I think we
can just remove these lines.